(GH-502) Correct path separator in nuspec file element #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Fixes: chocolatey/choco#502
|
@ferventcoder Ready for a re-review |
|
@ferventcoder |
6 tasks
|
Here is the previous commit in choco as to why switching the seperator on Windows is needed as well: chocolatey/choco@e5a02a0 |
|
This has been rebased and merged here: a8e3432 I will go ahead and close out this PR. Thanks for getting this updated, appreciate it! |
|
For future folks looking at this PR, the issue referenced in this PR, and in the commit message, references the issue on the chocolatey/choco repository. For future PR's, we should replicate the issue in this repository, so that we can correctly hook everything up. |
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this pull request
May 7, 2021
When using a relative path, pack only works if the current directory is the same as the directory containing the nuspec. This switches the relative path to an absolute path for non-windows platforms (windows already uses an absolute path). This change allows pack to work from any directory. Previously, in c0b23a6 and e5a02a0, non-windows platforms were switched to using a relative path for files, so that the default files separator in the nuspec files element could be switched to a backslash (chocolatey#2166) However, the issue with forward/back slashes is fixed by chocolatey/nuget-chocolatey#19, so the previous change can now be reverted.
gep13
pushed a commit
to TheCakeIsNaOH/choco
that referenced
this pull request
May 10, 2021
When using a relative path, pack only works if the current directory is the same as the directory containing the nuspec. This switches the relative path to an absolute path for non-windows platforms (windows already uses an absolute path). This change allows pack to work from any directory. Previously, in c0b23a6 and e5a02a0, non-windows platforms were switched to using a relative path for files, so that the default files separator in the nuspec files element could be switched to a backslash (chocolatey#2166) However, the issue with forward/back slashes is fixed by chocolatey/nuget-chocolatey#19, so the previous change can now be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the path separator character in the nuspec file source to the
character that is correct for the OS that is running the packing
operation. Changes
"\"to"/"on Linux and MacOS systems, andchanges
"/"to"\"on Windows systems.Fixes: chocolatey/choco#502
Fixes: chocolatey/choco#2166